[PATCH] D68410: [AttrDocs] document always_inline

Fri Dec 4 15:56:00 PST 2020

jdoerfert added a comment.

LGTM

================
Comment at: clang/include/clang/Basic/AttrDocs.td:4401
+disabled. Does not guarantee that inline substitution actually occurs.
+}];
+  let Heading = "always_inline";
----------------
nickdesaulniers wrote:
> lebedev.ri wrote:
> > jdoerfert wrote:
> > > It is more than that. This would imply that with optimizations enabled there is no effect. I would mention that the inline heuristic is disabled and inlining is always attempted, w/ or w/o optimizations.
> > This comment wasn't addressed.
> I don't follow. I'm not sure if this comment has bit rot?  I think it's critical to mention that `always_inline` does not mean always, as inline substitution MAY fail.
Original text:
> Hint that inline substitution should be attempted when optimizations are
disabled. Does not guarantee that inline substitution actually occurs.

The new text is better.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68410/new/

https://reviews.llvm.org/D68410