[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

Fri Dec 4 12:30:20 PST 2020

dblaikie added subscribers: scott.linder, JDevlieghere.
dblaikie added inline comments.

================
Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:22
+// Make sure we do not see any dwarf version other than 2, regardless of what's used on the host side.
+// CHECK-NOT: {{-dwarf-version=[^2]}}
 // CHECK: "-triple" "x86_64
----------------
tra wrote:
> MaskRay wrote:
> > A NOT pattern may easily become stale and do not actually check anything. Just turn to a positive pattern?
> In this case the issue is with the CHECK-NOT line above. I'll have to replicate it around the positive match of `-dwarf-version` which would raise more questions.
> 
> I wish filecheck would allow to `mark` a region and then run multiple matches on it, instead of re-anchoring on each match. 
Sounds like you're looking for CHECK-DAG, maybe? ( https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-dag-directive )

================
Comment at: clang/test/Driver/debug-options.c:364-366
+// GEMBED_2:  warning: debug information option '-gembed-source' is not supported for target
 // NOGEMBED_5-NOT:  "-gembed-source"
+// NOGEMBED_2-NOT:  warning: debug information option '-gembed-source' is not supported for target
----------------
This is a bit of a loss in fidelity - might need a new diagnostic message (or go hunting around for a more general purpose one than this one at least) to say '-gembed-source' is ignored when not using DWARFv5. (in the nvptx case it's "not supported on target", but in the existing cases covered by this test it's "not supported because the user requested DWARFv2", for instance)

@JDevlieghere & @scott.linder for thoughts on this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92617/new/

https://reviews.llvm.org/D92617