[PATCH] D92354: [clang] add a new `swift_attr` attribute

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added a comment.

Thanks for taking a look.

In D92354#2428604 <https://reviews.llvm.org/D92354#2428604>, @erik.pilkington wrote:

> Do we need to add APINotes support for this?

Not at the moment, maybe in the future



================
Comment at: clang/include/clang/Basic/Attr.td:2153
+def SwiftAttr : InheritableAttr {
+  let Spellings = [Clang<"swift_attr">];
+  let Args = [StringArgument<"Attribute">];
----------------
aaron.ballman wrote:
> The other swift attributes use a GNU spelling and don't expose any C++ spelling. Should this follow suit (or should the other attributes be updated)?
You're right, that was my mistake. Changed it to `GNU`.


================
Comment at: clang/include/clang/Basic/Attr.td:2155
+  let Args = [StringArgument<"Attribute">];
+  let Documentation = [SwiftAttrDocs];
+}
----------------
erik.pilkington wrote:
> Should we limit this to appear on certain subjects? Presumably the swift importer is only going to look for this in certain places, so I think it makes sense to call out places where it'll be ignored in clang. WDYT?
I think we want to leave it as a flexible attribute that can be applied to any declaration for now, and let the Swift importer decide on which declarations it wants to support them.


================
Comment at: clang/include/clang/Basic/AttrDocs.td:3635
+  let Content = [{
+The ``swift_attr`` provides a Swift-specific annotation for the declaration
+to which the attribute appertains to. This kind of annotation is ignored by
----------------
aaron.ballman wrote:
> What declarations does this attribute appertain to?
Mentioned that it can be applied to any declaration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92354/new/

https://reviews.llvm.org/D92354