[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

[Anastasiia Lukianenko via Phabricator via cfe-commits]

anastasiia_lukianenko added a comment.

For now without my patch current behavior is the following:
Your examples listed below:

  asm("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
      : "DEF"
      : "GHI");
  
  asm volatile(
      "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
      : "DEF"
      : "GHI");
  
  asm("AAAAAAAAAAAAAAAAAAA" : "DEF" : "GHI");
  
  asm volatile("AAAAAAAAAAAAA" : "DEF" : "GHI");
  
  asm volatile("AAAAAAAAAAAAA" : "DEF"(dst) : "GHI"(src));
  asm volatile("AAAAAAAAAAAAA" : "DEF"(dst));
  
  asm volatile("AAAAAAAAAAAAA" : [Foo] "DEF"(dst) : [Foo] "GHI"(src));
  asm volatile("AAAAAAAAAAAAA" : % [Foo] "DEF"(dst) : % [Foo] "GHI"(src));

Formatted with clang-format in this way:

  asm("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
      : "DEF"
      : "GHI");
  
  asm volatile(
      "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
      : "DEF"
      : "GHI");
  
  asm("AAAAAAAAAAAAAAAAAAA" : "DEF" : "GHI");
  
  asm volatile("AAAAAAAAAAAAA" : "DEF" : "GHI");
  
  asm volatile("AAAAAAAAAAAAA" : "DEF"(dst) : "GHI"(src));
  asm volatile("AAAAAAAAAAAAA" : "DEF"(dst));
  
  asm volatile("AAAAAAAAAAAAA" : [Foo] "DEF"(dst) : [Foo] "GHI"(src));
  asm volatile("AAAAAAAAAAAAA" : % [Foo] "DEF"(dst) : % [Foo] "GHI"(src));

So that's why my patch is breaking only long strings. If this is a bug, I can try to fix it. Then I update my patch so the configuration will be as @MyDeveloperDay expected.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91950/new/

https://reviews.llvm.org/D91950