[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 3 20:12:14 PST 2020


tra added inline comments.


================
Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:22
+// Make sure we do not see any dwarf version other than 2, regardless of what's used on the host side.
+// CHECK-NOT: {{-dwarf-version=[^2]}}
 // CHECK: "-triple" "x86_64
----------------
MaskRay wrote:
> A NOT pattern may easily become stale and do not actually check anything. Just turn to a positive pattern?
In this case the issue is with the CHECK-NOT line above. I'll have to replicate it around the positive match of `-dwarf-version` which would raise more questions.

I wish filecheck would allow to `mark` a region and then run multiple matches on it, instead of re-anchoring on each match. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92617/new/

https://reviews.llvm.org/D92617



More information about the cfe-commits mailing list