[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 17:08:55 PST 2020


shafik added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:2522
+  // Add to the lookupTable because we could not do that in MapImported.
+  Importer.AddToLookupTable(ToTypedef);
+
----------------
I am not super excited about this solution, I feel like several bugs we have had can be attributed to these exception control flow cases that we have in the ASTImporter. I don't have any immediate better solution.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92209/new/

https://reviews.llvm.org/D92209



More information about the cfe-commits mailing list