[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

[Min-Yih Hsu via Phabricator via cfe-commits]

myhsu added inline comments.


================
Comment at: clang/lib/Basic/Targets.cpp:314
+    default:
+      return new M68kTargetInfo(Triple, Opts);
+    }
----------------
rengolin wrote:
> No support for bare-metal?
currently we don't have any plan for that


================
Comment at: clang/lib/Basic/Targets/M68k.cpp:123
+    "d0", "d1", "d2", "d3", "d4", "d5", "d6", "d7",
+    "a0", "a1", "a2", "a3", "a4", "a5", "a6", "a7"};
+
----------------
rengolin wrote:
> no "sp", "pc", etc? Or are all of them aliased to those?
stack pointer is aliased to `a7`, but I'll add `pc` into the list.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8083
+
+// TODO Does not actually work right now
+void M68kTargetCodeGenInfo::setTargetAttributes(
----------------
rengolin wrote:
> That's an odd comment... :)
> 
> What doesn't work right now? Something or everything?
Seems to work after I fixed a minor issue in getting the correct TargetCodeGenInfo. Will remove this comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88393/new/

https://reviews.llvm.org/D88393