[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anton Zabaznov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 24 05:48:12 PST 2020


azabaznov added a comment.

Hi! Great to see the interest in OpenCL C 3.0!

I'm being working already at a proper feature macros definition to unify both clang and header OpenCL C 3.0 related changes, here is the change: https://reviews.llvm.org/D89869. So as this patch will be merged then the check for supported feature can be done uniformly in all OpenCL versions:

Use:

  #ifdef __opencl_c_pipes

instead of

  #if defined(__OPENCL_CPP_VERSION__) || (__OPENCL_C_VERSION__ >= CL_VERSION_2_0 && __OPENCL_C_VERSION__ < CL_VERSION_3_0) || (__OPENCL_C_VERSION__ >= CL_VERSION_3_0 && defined(__opencl_c_pipes))

The main concepts are described in RFC thread here: https://lists.llvm.org/pipermail/cfe-dev/2020-September/066883.html. Will be glad to discuss any technical details and concerns. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92004/new/

https://reviews.llvm.org/D92004



More information about the cfe-commits mailing list