[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

This looks great! Thanks a lot for bearing with me and doing all of this!



================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1613
+    if (auto CHI = declToCallHierarchyItem(*Decl))
+      Result.emplace_back(*std::move(CHI));
+  }
----------------
please put the deref inside `std::move`. as move semantics of `Optional` are optional (no pun intended :P), i.e. depends on `LLVM_HAS_RVALUE_REFERENCE_THIS`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91122/new/

https://reviews.llvm.org/D91122