[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 16 09:35:07 PST 2020


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM.

Patch description could use a pointer to more details about the unsafe atomics.



================
Comment at: clang/include/clang/Basic/TargetOptions.h:78
 
+  /// \brief If enabled, allow AMDGPU unsafe floating point atomics.
+  bool AllowAMDGPUUnsafeFPAtomics = false;
----------------
I'm curious -- what does `unsafe` mean here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91546/new/

https://reviews.llvm.org/D91546



More information about the cfe-commits mailing list