[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

[David Tenty via Phabricator via cfe-commits]

daltenty added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137
 
-    if (D.CCCIsCXX())
+    if (D.CCCIsCXX() || D.CCCIsCC())
       CmdArgs.push_back(Args.MakeArgString(
----------------
I think that rather that adding CC, we should just pull the if and unconditionally link crti.o. This is consistent with what is done on other platforms and since the `llvm.global_c/dtors` are generally allowable in the IR, we might see them in more than just the two driver scenarios suggested here.


================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:146
+  // forward.
+  if (D.CCCIsCXX() || D.CCCIsCC())
     CmdArgs.push_back("-bcdtors:all:0:s");
----------------
Ditto the previous comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91361/new/

https://reviews.llvm.org/D91361