[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 11:47:46 PDT 2020


dblaikie added subscribers: mehdi_amini, dblaikie.
dblaikie added a comment.

@lattner minor detail/annoyance: Phabricator doesn't email the mailing lists if a review is "approved" with no comments. To ensure the approval is recorded on the list, please include some text (a stub "." would suffice, but folks usually go with "Thanks!" or similar) - otherwise it looks sort of like patches are being committed without review, if you're just reading the mailing list.
@mehdi_amini: Any chance this might be fixable on the Phab side?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89893/new/

https://reviews.llvm.org/D89893



More information about the cfe-commits mailing list