[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

Mon Oct 26 05:29:42 PDT 2020

njames93 added a comment.

In D80531#2353314 <https://reviews.llvm.org/D80531#2353314>, @kkleine wrote:

> @njames93 I could do that but the original Macros had were defined without a semicolon at the end and one had to add it manually. See this revision in which I replaced some occurrences of `DISALLOW_COPY_AND_ASSIGN`: eaebcbc67926a18befaa297f1778edde63baec9b <https://reviews.llvm.org/rGeaebcbc67926a18befaa297f1778edde63baec9b>. What do you suggest? Keep the semicolon to more closely match the original macros or remove it to make the test happy?

Or add `-Wno-extra-semi` in the tests where you invoke clang-tidy directly, That'll silence the warnings and leave the rest of the test as-is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80531/new/

https://reviews.llvm.org/D80531