[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 23 16:52:41 PDT 2020


arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:222
       if (File)
         // FIXME: Use correctly named FileEntryRef.
+        Delegate->FileSkipped(*File, SynthesizedFilenameTok, Inc.FileKind);
----------------
You can drop the FIXME here now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89514/new/

https://reviews.llvm.org/D89514



More information about the cfe-commits mailing list