[PATCH] D89801: [SystemZ][ZOS] Set short-enums as the default for z/OS

Jonathan Crowther via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 20 08:48:33 PDT 2020


Jonathan.Crowther created this revision.
Jonathan.Crowther added reviewers: rsmith, abhina.sreeskantharajan, dlj.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Jonathan.Crowther requested review of this revision.

This patch sets short-enums to be the default for z/OS.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89801

Files:
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/test/Driver/zos-driver-defaults.c


Index: clang/test/Driver/zos-driver-defaults.c
===================================================================
--- /dev/null
+++ clang/test/Driver/zos-driver-defaults.c
@@ -0,0 +1,5 @@
+// RUN: %clang -### --target=s390x-none-zos -fsyntax-only %s 2>&1 | FileCheck %s
+// REQUIRES: clang-driver
+
+//CHECK: -fshort-enums
+//CHECK: -fno-signed-char
Index: clang/lib/Driver/ToolChains/Clang.cpp
===================================================================
--- clang/lib/Driver/ToolChains/Clang.cpp
+++ clang/lib/Driver/ToolChains/Clang.cpp
@@ -5560,9 +5560,9 @@
                        (RTTIMode == ToolChain::RM_Disabled)))
     CmdArgs.push_back("-fno-rtti");
 
-  // -fshort-enums=0 is default for all architectures except Hexagon.
+  // -fshort-enums=0 is default for all architectures except Hexagon and z/OS.
   if (Args.hasFlag(options::OPT_fshort_enums, options::OPT_fno_short_enums,
-                   TC.getArch() == llvm::Triple::hexagon))
+                   TC.getArch() == llvm::Triple::hexagon || Triple.isOSzOS()))
     CmdArgs.push_back("-fshort-enums");
 
   RenderCharacterOptions(Args, AuxTriple ? *AuxTriple : RawTriple, CmdArgs);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89801.299369.patch
Type: text/x-patch
Size: 1161 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201020/116e053c/attachment.bin>


More information about the cfe-commits mailing list