[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In D89559#2336335 <https://reviews.llvm.org/D89559#2336335>, @rjmccall wrote:

> We can't have it always match, that would require us to reject the conversion to a bare function-pointer type, which is required by the standard.
>
> I'm not sure if MSVC's multiple conversions hack is conformant or not, but it's at least more conformant than that.

Right, I should have remembered that.  Though, I guess that brings up the alternative, which is to simply produce ALL of the conversion/invoke functions like MSVC.  I was originally attempting to implement that (under a MSVCCompat flag) and decided fixing this first would be an easier way to go, but I could just continue with that implementation for ALL valid CCs on all platforms.

It is slightly more difficult than just this I believe, as there is some codegen error that I need to fix, but otherwise it should be fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89559/new/

https://reviews.llvm.org/D89559