[PATCH] D89579: [clangd][ObjC] Support nullability annotations

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 16 11:42:09 PDT 2020


dgoldman added inline comments.


================
Comment at: clang-tools-extra/clangd/Selection.cpp:621-623
+      if (auto AT = TL->getAs<AttributedTypeLoc>())
+        S = AT.getModifiedLoc()
+                .getSourceRange(); // should we just return false?
----------------
Let me know if you think it would be better to return false here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89579/new/

https://reviews.llvm.org/D89579



More information about the cfe-commits mailing list