[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 16 10:17:49 PDT 2020


rjmccall added inline comments.


================
Comment at: clang/lib/Sema/SemaLambda.cpp:1278
+  if (CallOpCC == DefaultMember)
+    return DefaultFree;
+  return CallOpCC;
----------------
...I made this comment in my first review, but Phabricator threw it away.

The attributes let you explicitly request the default method CC, right?  I think you need to check for an explicit attribute rather than just checking CC identity.  There should be an AttributedType in the sugar.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89559/new/

https://reviews.llvm.org/D89559



More information about the cfe-commits mailing list