[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Thu Oct 15 00:28:02 PDT 2020

Tyker added a comment.

In D63640#2331734 <https://reviews.llvm.org/D63640#2331734>, @martong wrote:

> In D63640#2331410 <https://reviews.llvm.org/D63640#2331410>, @rsmith wrote:
>
>> Reverse ping: I have a patch implementing class type non-type template parameters that's blocked on this landing. If you won't have time to address @martong's comments soon, do you mind if I take this over and land it?
>
> It is okay for me to commit this patch in its current state. The changes I suggested could result in a cleaner code, but I can do those changes after we land this.

i couldn't apply martong's suggestion because importChecked is part of ASTNodeImporter not ASTImporter, but cleaned up some code.
but the "real" blocker is that the testing depends on D85144 <https://reviews.llvm.org/D85144> for testing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63640/new/

https://reviews.llvm.org/D63640