[PATCH] D89429: clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 14 15:12:04 PDT 2020


dexonsmith created this revision.
dexonsmith added a reviewer: arphaman.
Herald added a subscriber: ributzka.
dexonsmith requested review of this revision.

Replace `SourceManager::getMemoryBufferForFile`, which returned a
dereferenceable `MemoryBuffer*` and had a `bool*Invalid` out parameter,
with `getMemoryBufferForFileOrNone` (returning
`Optional<MemoryBufferRef>`) and `getMemoryBufferForFileOrFake`
(returning `MemoryBufferRef`).


https://reviews.llvm.org/D89429

Files:
  clang/include/clang/Basic/SourceManager.h
  clang/include/clang/Frontend/PrecompiledPreamble.h
  clang/lib/Basic/SourceManager.cpp
  clang/lib/Frontend/PrecompiledPreamble.cpp
  clang/lib/Lex/Preprocessor.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89429.298248.patch
Type: text/x-patch
Size: 5245 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201014/b6fc6c2c/attachment.bin>


More information about the cfe-commits mailing list