[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 14 07:13:11 PDT 2020


dexonsmith updated this revision to Diff 298144.
dexonsmith added a comment.

Cleaned up the (fixed) `Invalid` logic to reduce the size of the diff and use a consistent pattern. Thanks for you patience with the false start; I think this is ready now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89348/new/

https://reviews.llvm.org/D89348

Files:
  clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
  clang/include/clang/Basic/SourceManager.h
  clang/lib/AST/ASTImporter.cpp
  clang/lib/Basic/SourceManager.cpp
  clang/lib/Serialization/ASTWriter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89348.298144.patch
Type: text/x-patch
Size: 16726 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201014/2df865f3/attachment-0001.bin>


More information about the cfe-commits mailing list