[PATCH] D89184: Support complex target features combinations

Pengfei Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 14 00:32:44 PDT 2020


pengfei added a comment.

> D89105 <https://reviews.llvm.org/D89105>  appears to use only `"avx512vl , avx512vnni | avxvnni"`.
> Does it mean `(avx512vl , avx512vnni) | avxvnni` or `avx512vl , (avx512vnni | avxvnni)` ?

We need to express combination to `(avx512vl , avx512vnni) | avxvnni`, the previous code will turn it into `avx512vl , (avx512vnni | avxvnni)`.
With this patch, `"avx512vl , avx512vnni | avxvnni"` will turn into `(avx512vl , avx512vnni) | avxvnni` by always prioritizing `","`.
I agreed with @echristo that we do need to add some comments for that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89184/new/

https://reviews.llvm.org/D89184



More information about the cfe-commits mailing list