[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

Venkataramanan Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 13 11:42:45 PDT 2020


venkataramanan.kumar.llvm updated this revision to Diff 297925.
venkataramanan.kumar.llvm added a comment.

Updated the patch as per review comments received.

The test cases are updated the checks based on the below comment from Francesco.

---Snip--
I think you are over-testing here. It is enough to check that inside the vector body there is a call to the vector function you have listed in the mapping.
---Snip--  
Florian also suggesting the same.

I still use metadata suggested by Sanjay . Currently testing only VF=4 . This is because we have float and double type lib calls in the test case and libmvec has vector call support for VF=4 .    For VF say 8  there is vector call support for double types.

I can add few more test with meta data to cover floats with VF=8.   please let me know your suggestions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88154/new/

https://reviews.llvm.org/D88154

Files:
  clang/include/clang/Basic/CodeGenOptions.def
  clang/include/clang/Basic/CodeGenOptions.h
  clang/include/clang/Driver/Options.td
  clang/lib/CodeGen/BackendUtil.cpp
  clang/lib/Frontend/CompilerInvocation.cpp
  clang/test/Driver/autocomplete.c
  clang/test/Driver/fveclib.c
  llvm/include/llvm/Analysis/TargetLibraryInfo.h
  llvm/include/llvm/Analysis/VecFuncs.def
  llvm/lib/Analysis/TargetLibraryInfo.cpp
  llvm/test/CodeGen/X86/cpus-other.null
  llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls-finite.ll
  llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls.ll
  llvm/test/Transforms/Util/add-TLI-mappings.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88154.297925.patch
Type: text/x-patch
Size: 32795 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201013/e0a0ffeb/attachment-0001.bin>


More information about the cfe-commits mailing list