[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 12 06:18:19 PDT 2020


erichkeane added a comment.

In D76620#2324119 <https://reviews.llvm.org/D76620#2324119>, @rjmccall wrote:

> Richard and I just found out about this commit, and we've decided to revert it.  I apologize for the very late reversion, but the reality of Clang development is that it's very difficult for the code owners to watch literally every commit, and we rely on the community to follow policies and bring things to our attention when there's a question about the right thing to do.  This is a new feature that was submitted without properly following any of the guidelines for new features: it was neither approved by a relevant standards body, added for compatibility with an existing frontend, or taken through the RFC process.  If you had brought it to our attention as an RFC, we would've expressed serious concerns about the design.
>
> Please start an RFC thread and CC Richard and me.

The feature that this supports is a part of the SYCL 2020 Provisional Spec, I thought that was sufficient.  We'll look into an RFC to re-submit in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76620/new/

https://reviews.llvm.org/D76620



More information about the cfe-commits mailing list