[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

[Kevin P. Neal via Phabricator via cfe-commits]

kpn added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:139
+
+  switch (E->getStmtClass()) {
+  case Stmt::UnaryOperatorClass: {
----------------
sepavloff wrote:
> Actually this is not correct, because subclass relations are not preserved in this case. For instance, `CompounsAssignmentOperator` is not handled, as it does not return `BinaryOperatorClass`.
> 
> I would recommend using `Expr::getFPFeaturesInEffect` or adding similar method.
That's much cleaner. Sorry I missed that earlier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88913/new/

https://reviews.llvm.org/D88913