[PATCH] D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets

Thu Oct 8 01:00:56 PDT 2020

jhenderson added inline comments.

================
Comment at: clang/lib/Basic/Cuda.cpp:1
 #include "clang/Basic/Cuda.h"

----------------
(aside - this file seems to be missing the copyright header - probably should be fixed separately though)

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1733
 static const EnumEntry<unsigned> ElfHeaderAMDGPUFlags[] = {
   LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_NONE),
   LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_R600_R600),
----------------
I'm not sure what exactly clang-format is complaining about here, but it might be worth reformatting this enum as requested, possibly as a separate commit, I don't mind.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88916/new/

https://reviews.llvm.org/D88916