[PATCH] D88970: [clangd] Fix argument type (bool->float).

Adam Czachorowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 7 08:09:21 PDT 2020


adamcz created this revision.
adamcz added a reviewer: usaxena95.
Herald added subscribers: cfe-commits, kadircet, arphaman.
Herald added a project: clang.
adamcz requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.

The default value is 1.3f, but it was cast to true, which is not a good
base for code completion score.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88970

Files:
  clang-tools-extra/clangd/tool/ClangdMain.cpp


Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
===================================================================
--- clang-tools-extra/clangd/tool/ClangdMain.cpp
+++ clang-tools-extra/clangd/tool/ClangdMain.cpp
@@ -185,7 +185,7 @@
     Hidden,
 };
 
-opt<bool> DecisionForestBase{
+opt<float> DecisionForestBase{
     "decision-forest-base",
     cat(Features),
     desc("Base for exponentiating the prediction from DecisionForest."),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88970.296682.patch
Type: text/x-patch
Size: 443 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201007/39db7ae2/attachment-0001.bin>


More information about the cfe-commits mailing list