[PATCH] D88828: [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC.

Tue Oct 6 01:56:54 PDT 2020

hokein added a comment.

In D88828#2311679 <https://reviews.llvm.org/D88828#2311679>, @kadircet wrote:

> LGTM, but can you add some description about why you've decided to do it now :D

yeah, this comes up when I read the code, I think it is easier to spot which diagnostics in the include-fixer list are tested, (e.g. `err_incomplete_type` is not tested yet).

And my next step to see whether there are other missing diagnostics that could be fixed by inserting a header.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88828/new/

https://reviews.llvm.org/D88828