[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

Fri Oct 2 11:11:12 PDT 2020

shafik added a comment.

In D88665#2308366 <https://reviews.llvm.org/D88665#2308366>, @martong wrote:

>> In D88665#2307562 <https://reviews.llvm.org/D88665#2307562>, @shafik wrote:
>>
>>> So was the bug we were saying there were falsely equivalent or falsely not equivalent?
>>
>> I think the bug is the crash :)
>
> Yes. More specifically, the call of `getBitWidthValue()` caused a segfault with release builds and with assertions enabled it caused the mentioned assert on the given test code.

Thank you! From the test it was not obvious what was the actual cause of the crash so evaluating the correctness was difficult.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88665/new/

https://reviews.llvm.org/D88665