[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 28 09:40:40 PDT 2020


vsk added a comment.

Thanks for the review!



================
Comment at: clang/lib/CodeGen/CGExpr.cpp:1181
+  if (T->isMemberPointerType())
+    return CGM.getCXXABI().EmitMemberPointerIsNotNull(
+        *this, V, T->getAs<MemberPointerType>());
----------------
ahatanak wrote:
> You can fold `T->getAs<MemberPointerType>()` into the condition of the if statement.
I'll fix this before committing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88336/new/

https://reviews.llvm.org/D88336



More information about the cfe-commits mailing list