[PATCH] D87187: [Driver] Perform Linux distribution detection just once

Dmitry Antipov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 25 07:31:26 PDT 2020


dmantipov updated this revision to Diff 294302.
dmantipov marked an inline comment as done.
dmantipov added a comment.

Well, the problem with tests seems to be a bit wider - tests uses  llvm::vfs::InMemoryFileSystem, which is not "real", so detection will return  Distro::UnknownDistro anyway. So I think we can just add fallback branch for such pseudo filesystems and live with current tests as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87187/new/

https://reviews.llvm.org/D87187

Files:
  clang/include/clang/Driver/Distro.h
  clang/lib/Driver/Distro.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87187.294302.patch
Type: text/x-patch
Size: 11966 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200925/57993051/attachment.bin>


More information about the cfe-commits mailing list