[clang] 276f68e - Revert "Add a static_assert confirming that DiagnosticBuilder is small"

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 16:40:15 PDT 2020


Author: Reid Kleckner
Date: 2020-09-24T16:39:46-07:00
New Revision: 276f68eace7c27f6805d69a30a4b2f186e42c56c

URL: https://github.com/llvm/llvm-project/commit/276f68eace7c27f6805d69a30a4b2f186e42c56c
DIFF: https://github.com/llvm/llvm-project/commit/276f68eace7c27f6805d69a30a4b2f186e42c56c.diff

LOG: Revert "Add a static_assert confirming that DiagnosticBuilder is small"

This reverts commit a32feed0dbeac7606d042d0d7e041c9eaf12cd51.

This assert doesn't hold in 32-bit builds, I didn't do the math right.

Added: 
    

Modified: 
    clang/lib/Basic/Diagnostic.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Basic/Diagnostic.cpp b/clang/lib/Basic/Diagnostic.cpp
index c98fa6ebf817..661eabf9bc7c 100644
--- a/clang/lib/Basic/Diagnostic.cpp
+++ b/clang/lib/Basic/Diagnostic.cpp
@@ -40,9 +40,6 @@
 
 using namespace clang;
 
-static_assert(sizeof(DiagnosticBuilder) <= 2 * sizeof(void *),
-              "DiagnosticBuilder should be small, see class doc comments");
-
 const DiagnosticBuilder &clang::operator<<(const DiagnosticBuilder &DB,
                                            DiagNullabilityKind nullability) {
   StringRef string;


        


More information about the cfe-commits mailing list