[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

[sameeran joshi via Phabricator via cfe-commits]

sameeranjoshi added a comment.

In D87774#2292034 <https://reviews.llvm.org/D87774#2292034>, @awarzynski wrote:

> @sameeranjoshi Apologies, I missed some of your comments.
>
> In D87774#2287927 <https://reviews.llvm.org/D87774#2287927>, @sameeranjoshi wrote:
>
>> Thanks for working on it.
>> Few comments inline:
>>
>> 1. For an out-of-tree build, I see `check-flang` target failing with
>>
>>   /unittests/Frontend/CompilerInstanceTest.cpp:17:10: fatal error: filesystem: No such file or directory
>>    #include <filesystem>
>>             ^~~~~~~~~~~~
>>
>> I used gcc/g++ 7.5 version.
>> I haven't checked in-tree still, and others/bots might have checked it.
>
> I haven't been able to reproduce it, but note that `filesystem` is a C++17 header. AFAIK, in GCC-7 you have to use `<experimental/filesystem>` instead of `<filesystem>`. This suggests README.md should be updated: https://github.com/llvm/llvm-project/blob/master/flang/README.md#supported-c-compilers (we probably need an RFC for this). Since this `#include` was introduced elsewhere, I suggest that we move this discussion either to Slack or flang-dev.

Do you know if there are any bots configured to handle out-of-tree changes?
That might be helpful to avoid configuration differences and test OFT patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87774/new/

https://reviews.llvm.org/D87774