[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

Thu Sep 24 10:02:26 PDT 2020

dblaikie added a comment.

In D81865#2293059 <https://reviews.llvm.org/D81865#2293059>, @MaskRay wrote:

> @froydnj The committed version rG31a3c5fb45b78bdaa78d94ffcc9258e839002016 <https://reviews.llvm.org/rG31a3c5fb45b78bdaa78d94ffcc9258e839002016> appears to be very different from the review. I guess next time your probably can upload the diff again if it is very diffierent

Judging by a cursory glance at Phab's view of the delta ( https://reviews.llvm.org/rG4b64ce7428b66cacfe74dbd9dbc29aff6dfb84af ) it /looks/ like it wasn't too different. Mostly picking up upstream changes that added "DEFERRABLE"? (I think Phab uses light green for "this changed, but only because of upstream changes" and dark green is the actual patch changes?)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81865/new/

https://reviews.llvm.org/D81865