[PATCH] D88222: [AST] Use data-recursion when building ParentMap, avoid stack overflow.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 08:19:23 PDT 2020


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

Thanks for fixing this!



================
Comment at: clang/lib/AST/ParentMapContext.cpp:231
+  template <typename MapNodeTy, typename MapTy>
+  void MarkChild(MapNodeTy MapNode, MapTy *Parents) {
+    if (ParentStack.empty())
----------------
can we make some comments explaining what this method does?  I think I have a vague understanding, but would be helpful to have some documentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88222/new/

https://reviews.llvm.org/D88222



More information about the cfe-commits mailing list