[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

Wed Sep 23 16:14:10 PDT 2020

dblaikie added a comment.

In D80531#2284388 <https://reviews.llvm.org/D80531#2284388>, @kkleine wrote:

> Hi @dblaikie . I did run `ninja check-all` and `/bin/llvm-lit -av ../clang-tools-extra/test/clang-tidy/checkers/modernize-replace-disallow-copy-and-assign-macro.cpp` on this very new revision (abd70fb3983f342bc1c90f9c70a7b59790ad5206 <https://reviews.llvm.org/rGabd70fb3983f342bc1c90f9c70a7b59790ad5206>) manually but I don't see this error coming up. Can you please try to test if you see the error on a fresh build?

Hey - thanks for gettiing back to me.

I've tried a /bunch/ of variants of my usual build lately, and this seems to be what I've hit a fairly reliable repro/no-repro:

  $ CC=clang CXX=clang++ cmake -G Ninja -DLLVM_ENABLE_WERROR=true  -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra' path/to/llvm/src
  $ ninja check-all

If I turn of LLVM_ENABLE_WERROR (either by deleting the whole build tree and starting again, omitting the -DLLVM_ENABLE_WERROR=true part, or by manually editing the existing CMakeCache.txt file) the failure on this test case goes away. If I turn on Werror again, the failure turns up again.

It's possible (I guess likely, or this would be failing on a bunch of buildbots, I imagine) that this has somtehing to do with my specific local build of clang that I'm using to build - but even then, it seems problematic that the LLVM_ENABLE_WERROR is affecting this test execution in any way.

Also, just in general - I wonder if this test and test infrastructure (check_clang_tidy) could be made more legible in some way (at least the failure message/reporting) - perhaps it's just my lack of familiarity and anyone working on the tool would be able to read what was going wrong here, but I can't make heads or tails of the failure, couldn't figure out how to extract a file showing the good/bad behavior so I Could compare it, etc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80531/new/

https://reviews.llvm.org/D80531