[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

Wed Sep 23 00:02:16 PDT 2020

JonasToth added a comment.

In D54943#2289037 <https://reviews.llvm.org/D54943#2289037>, @0x8000-0000 wrote:

> Master branch has too many false positives for tidy - would it be possible to create a branch that contains this patch set on top of llvm-11.0-rc3? I would then add this to our internal CI.

Yeah, it is not that simple to get this check into something really usefull :/
I can create a branch in my own fork, that would need a little work, which i can do in ~8 hours. I would then ping you.

> For the legacy code (see previous reports) we found quite a few false positives. For a new code base that we're developing from scratch with C++20, there have been no false positives - it catches missed 'const' much better than human reviewers - we still keep a Clang10 around that I built from source with the previous version of the patches :)

It would be great if you could keep testing your legacy code-base once this patch progresses even further.
It is a great message, that the modern codebase does not make big trouble :) Given I tested mostly on LLVM itself so far, this is not too surprising as its a modern codebase itself.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943