[PATCH] D87953: [xray] Function coverage groups

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 22 19:58:04 PDT 2020


MaskRay added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1136
+  if (Opts.XRayTotalFunctionGroups < 1) {
+    const Arg *A = Args.getLastArg(OPT_fxray_function_groups);
+    Diags.Report(diag::err_drv_invalid_value)
----------------
Errors here are not necessary. The driver has reported errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87953/new/

https://reviews.llvm.org/D87953



More information about the cfe-commits mailing list