[PATCH] D87839: [SyntaxTree] Test the List API

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 22 09:23:42 PDT 2020


eduucaldas marked an inline comment as done.
eduucaldas added inline comments.


================
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:224
+  /// "a, b  c"  <=> [("a", ","), ("b", nul), ("c", nul)]
+  /// "a, b,"    <=> [("a", ","), ("b", ","), (nul, nul)]
   ///
----------------
gribozavr2 wrote:
> I'd slightly prefer "null" b/c "nul" refers to the ASCII character. Feel free to add more spaces to make columns line up :)
Thanks for providing my solution to my crazyness ^^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87839/new/

https://reviews.llvm.org/D87839



More information about the cfe-commits mailing list