[PATCH] D87953: [xray] Function coverage groups

[Dean Michael Berris via Phabricator via cfe-commits]

dberris added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:817
+                                        CurFn->getName().bytes_end());
+      auto Group = crc32(FuncName) % FuncGroups;
+      if (Group != CGM.getCodeGenOpts().XRaySelectedFunctionGroup &&
----------------
I'm a little concerned that this is randomly determined. Could we think about using a function attribute instead that opts functions into groups by name? Or is the intent to have "sampling" in the coverage information instead of full coverage?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87953/new/

https://reviews.llvm.org/D87953