[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

Fri Sep 18 14:32:32 PDT 2020

yaxunl added a comment.

In D84362#2282965 <https://reviews.llvm.org/D84362#2282965>, @tra wrote:

> In D84362#2282890 <https://reviews.llvm.org/D84362#2282890>, @yaxunl wrote:
>
>> I have a fix for the issue reported in D84364 <https://reviews.llvm.org/D84364>. Would you like to try? Thanks.
>
> I can try it on the internal test that crashed with the patch. I've reopened this review and will pick up the diff once you update it.

The fix is for the change in D84364 <https://reviews.llvm.org/D84364>. It has no effect on the change in this review. Are you sure the issue you saw is due to change in this review instead of change in D84364 <https://reviews.llvm.org/D84364>?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84362/new/

https://reviews.llvm.org/D84362