[PATCH] D87943: [clang] Remove profile availabile check for fsplit-machine-functions.

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 18 14:22:38 PDT 2020


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm with a couple of minor suggestions



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4919
     if (Triple.isX86() && Triple.isOSBinFormatELF()) {
       if (A->getOption().matches(options::OPT_fsplit_machine_functions)) {
           A->render(Args, CmdArgs);
----------------
nit, remove braces per coding convention.


================
Comment at: clang/test/Driver/fsplit-machine-functions.c:3
 // RUN: %clang -### -target x86_64 -fprofile-use=default.profdata -fsplit-machine-functions -fno-split-machine-functions %s -c 2>&1 | FileCheck -check-prefix=CHECK-NOOPT %s
-// RUN: %clang -### -target x86_64 -fsplit-machine-functions %s 2>&1 | FileCheck -check-prefix=CHECK-WARN %s
 // RUN: not %clang -c -target arm-unknown-linux -fsplit-machine-functions %s 2>&1 | FileCheck -check-prefix=CHECK-TRIPLE %s
----------------
Might want to check that we get the option despite not having fprofile-use


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87943/new/

https://reviews.llvm.org/D87943



More information about the cfe-commits mailing list