[PATCH] D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces.

Adam Czachorowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 18 07:31:15 PDT 2020


adamcz added inline comments.


================
Comment at: clang-tools-extra/clangd/Config.h:70
+    // declarations, always spell out the whole name (with or without leading
+    // ::). All nested namespaces are affected as well.
+    std::vector<std::string> FullyQualifiedNamespaces;
----------------
sammccall wrote:
> should just be "without leading ::" now I think?
What I was trying to say here is that both ::foo::bar and foo::bar are allowed, but:
  using foo;
  bar
is not. Basically I'm trying to explain that what we mean by fully qualified is the no-using-shortcuts, not always-start-with-::

This isn't about what's stored in the vector, but rather what this options means.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87775/new/

https://reviews.llvm.org/D87775



More information about the cfe-commits mailing list