[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 18 01:13:06 PDT 2020


sammccall added inline comments.


================
Comment at: clang/lib/Sema/SemaOverload.cpp:12880
 
   return Result.getValueOr(QualType());
 }
----------------
Wouldn't we be better to handle undeduced type here rather than in the loop?

Not sure if it practically matters, but given: `auto f(); double f(int); f(0,0);`
the code in this patch will discard auto and yield `double`, while treating this as multiple candidates --> unknown return type seems more correct.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87350/new/

https://reviews.llvm.org/D87350



More information about the cfe-commits mailing list