[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

Sukraat Ahluwalia via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 17 17:14:18 PDT 2020


sukraat91 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:66
 
+bool isPassedToStdMove(const ParmVarDecl &Param, ASTContext &Context) {
+  // Check if the parameter has a name, in case of functions like -
----------------
aaron.ballman wrote:
> Can `Context` be `const ASTContext &`?
Unfortunately, no. This is because match() does not have an overload for `const ASTContext&`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87540/new/

https://reviews.llvm.org/D87540



More information about the cfe-commits mailing list