[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

Thu Sep 17 16:24:42 PDT 2020

aaronpuchert added a comment.

Looks pretty good, thanks! I think this clears up the misunderstandings.

Since I'm not a native speaker I'd like to wait for @aaron.ballman's opinion before we merge this.

================
Comment at: clang/docs/ThreadSafetyAnalysis.rst:128-135
 The set of capabilities that are actually held by a given thread at a given
 point in program execution is a run-time concept.  The static analysis works
 by calculating an approximation of that set, called the *capability
 environment*.  The capability environment is calculated for every program point,
 and describes the set of capabilities that are statically known to be held, or
 not held, at that particular point.  This environment is a conservative
 approximation of the full set of capabilities that will actually held by a
----------------
Wondering if we should refer to this somehow, but maybe I'm overthinking it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87629/new/

https://reviews.llvm.org/D87629