[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

[Artem Belevich via Phabricator via cfe-commits]

tra added a comment.

Apparently this patch triggers compiler crashes on some of our code. I'll try to create a reproducer, but it would be great to revert the patch for now.

  *** SIGSEGV (@0x7f68892d8fe8),  received by PID 8210 (TID 8225) on cpu 65; stack trace: ***
  PC: @     0x7f686d8a169d  (unknown)  clang::Decl::getAvailability()
      @     0x7f6712fad13b       1376  FailureSignalHandler()
      @     0x7f696f1b69a0      34448  (unknown)
      @     0x7f688c278c9a        352  ShouldDiagnoseAvailabilityOfDecl()
      @     0x7f688c27897d        352  clang::Sema::DiagnoseAvailabilityOfDecl()
      @     0x7f688c8bd3c7       1584  clang::Sema::DiagnoseUseOfDecl()
      @     0x7f688c8cc1e8        672  clang::Sema::BuildDeclarationNameExpr()
      @     0x7f688c8c9e30        192  clang::Sema::BuildDeclarationNameExpr()
      @     0x7f688c8c2698       1280  clang::Sema::ActOnIdExpression()
      @     0x7f688e9b95db       9136  clang::Parser::ParseCastExpression()
      @     0x7f688e9b358b        128  clang::Parser::ParseCastExpression()
      @     0x7f688e9b9ebb       9136  clang::Parser::ParseCastExpression()
      @     0x7f688e9b358b        128  clang::Parser::ParseCastExpression()
      @     0x7f688e9b1998        112  clang::Parser::ParseAssignmentExpression()
      @     0x7f688e9b1832         64  clang::Parser::ParseExpression()
      @     0x7f688e9bd6f0       4064  clang::Parser::ParseParenExpression()
      @     0x7f688e9b6bb4       9136  clang::Parser::ParseCastExpression()
      @     0x7f688e9b358b        128  clang::Parser::ParseCastExpression()
      @     0x7f688e9b1998        112  clang::Parser::ParseAssignmentExpression()
      @     0x7f688e9c1285        288  clang::Parser::ParseExpressionList()
      @     0x7f688e9b4731       3088  clang::Parser::ParsePostfixExpressionSuffix()
      @     0x7f688e9bb92a       9136  clang::Parser::ParseCastExpression()
      @     0x7f688e9b358b        128  clang::Parser::ParseCastExpression()
      @     0x7f688e9b1998        112  clang::Parser::ParseAssignmentExpression()
      @     0x7f688e9b1832         64  clang::Parser::ParseExpression()
      @     0x7f688ea43040        240  clang::Parser::ParseReturnStatement()
      @     0x7f688ea3cef0       1264  clang::Parser::ParseStatementOrDeclarationAfterAttributes()
      @     0x7f688ea3c5cf        160  clang::Parser::ParseStatementOrDeclaration()
      @     0x7f688ea4490a       1264  clang::Parser::ParseCompoundStatementBody()
      @     0x7f688ea45df9        272  clang::Parser::ParseFunctionStatementBody()
      @     0x7f688ea6a7b4        960  clang::Parser::ParseFunctionDefinition()
      @     0x7f688e9600bd       2880  clang::Parser::ParseDeclGroup()
      @     0x7f688ea69634        368  clang::Parser::ParseDeclOrFunctionDefInternal()
      @     0x7f688ea68c20        672  clang::Parser::ParseDeclarationOrFunctionDefinition()
      @     0x7f688ea684ee        768  clang::Parser::ParseExternalDeclaration()
      @     0x7f688ea667a9        368  clang::Parser::ParseTopLevelDecl()
      @     0x7f688e93d2a2        240  clang::ParseAST()
      @     0x7f688fe079bd         80  clang::ASTFrontendAction::ExecuteAction()
      @     0x7f688fe073b8        144  clang::FrontendAction::Execute()
      @     0x7f688fd1bdd6        480  clang::ASTUnit::Parse()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84362/new/

https://reviews.llvm.org/D84362