[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

Sat Sep 12 06:57:32 PDT 2020

fhahn added inline comments.

================
Comment at: clang/include/clang/Driver/Options.td:4287-4290
+def fpass_by_value_noalias: Flag<["-"], "fpass-by-value-noalias">,
+  HelpText<"Allows assuming no references to passed by value escape before "
+           "transferring execution to the called function. Note that this "
+           "does not hold for C++">;
----------------
rjmccall wrote:
> fhahn wrote:
> > rjmccall wrote:
> > > rsmith wrote:
> > > > This should be in `Group<f_Group>`.
> > > The "Note" clause seems to muddy more than it clarifies.  Maybe "has no effect on non-trivially-copyable classes in C++"?  Or add proper documentation somewhere instead of trying to jam this into the help text.
> > I've added the clarification, thanks!
> Oh, you need a space after the period.
Done, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85473/new/

https://reviews.llvm.org/D85473