[PATCH] D87321: Fix -gz=zlib options for linker

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 11 11:17:07 PDT 2020


yaxunl added inline comments.


================
Comment at: clang/test/Driver/compress.c:26
+// CHECK-OPT_GZ_EQ_NONE: {{".*clang.*".* "--compress-debug-sections=none"}}
+// CHECK-OPT_GZ_EQ_NONE: {{".*ld.*".* "--compress-debug-sections=none"}}
+
----------------
MaskRay wrote:
> If the user sets CLANG_DEFAULT_LINKER to a string not containing "ld", this line will not match. Matching a different substring on the linker command line can be more robust, e.g. `"-m" "elf_x86_64"`
"-m" "elf_x86_64" only works for x86_64, but we also have amdgcn target.

I will just remove "ld".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87321/new/

https://reviews.llvm.org/D87321



More information about the cfe-commits mailing list