[PATCH] D87358: [clang][aarch64] Fix ILP32 ABI for arm_sve_vector_bits

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 9 18:02:07 PDT 2020


efriedma added inline comments.


================
Comment at: clang/lib/AST/Type.cpp:2339
   case BuiltinType::SveInt32:
-    return Ctx.IntTy;
+    return IsILP32 ? Ctx.LongTy : Ctx.IntTy;
   case BuiltinType::SveUint32:
----------------
sdesmalen wrote:
> Rather than comparing with a specific triple, how about getting the information from `TargetInfo`, i.e.
> 
>   case BuiltinType::SveInt32:
>     Ctx.getTargetInfo().getLongWidth() == 32 ? Ctx.LongTy : Ctx.IntTy
The type that actually corresponds to int64_t is TargetInfo::getInt64Type().  Not sure if you need that here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87358/new/

https://reviews.llvm.org/D87358



More information about the cfe-commits mailing list